[Libstoragemgmt-devel] [PATCH 0/3] Bug fixes about volume_raid_info() API.

[Gris Ge]

* ONTAP plugin fixes.
* lsmcli manpage update.

Gris Ge (3):
ONTAP Plugin: Add missing capability VOLUME_RAID_INFO.
ONTAP Plugin: Fix bug an incorrect constant.
lsmcli: Add missing manpage entries for volume-raid-info command.

doc/man/lsmcli.1.in | 9 +++++++++
plugin/ontap/ontap.py | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)

[Gris Ge]

* Add missing capability lsm.Capabilities.VOLUME_RAID_INFO.

Signed-off-by: Gris Ge <***@redhat.com>
---
plugin/ontap/ontap.py | 1 +
1 file changed, 1 insertion(+)

diff --git a/plugin/ontap/ontap.py b/plugin/ontap/ontap.py
index b6358a8..6cf8cd5 100644
--- a/plugin/ontap/ontap.py
+++ b/plugin/ontap/ontap.py
@@ -534,6 +534,7 @@ class Ontap(IStorageAreaNetwork, INfs):
cap.set(Capabilities.EXPORT_CUSTOM_PATH)
cap.set(Capabilities.TARGET_PORTS)
cap.set(Capabilities.DISKS)
+ cap.set(Capabilities.VOLUME_RAID_INFO)
return cap

@handle_ontap_errors

[Gris Ge]

* Add manpage section for volume-raid-info command and its
alias 'vri'.

Signed-off-by: Gris Ge <***@redhat.com>
---
doc/man/lsmcli.1.in | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/doc/man/lsmcli.1.in b/doc/man/lsmcli.1.in
index ec4e3eb..e2af14f 100644
--- a/doc/man/lsmcli.1.in
+++ b/doc/man/lsmcli.1.in
@@ -344,6 +344,13 @@ Required. The ID of volume to revoke.
\fB--ag\fR \fI<AG_ID>\fR
Required. The ID of access group to revoke.

+.SS volume-raid-info
+.TP 15
+Query RAID information for given volume.
+.TP
+\fB--vol\fR \fI<VOL_ID>\fR
+Required. The ID of volume to query.
+
.SS access-group-create
.TP 15
Create an access group.
@@ -580,6 +587,8 @@ Alias of 'volume-resize'
Alias of 'volume-mask'
.SS vu
Alias of 'volume-unmask'
+.SS vri
+Alias of 'volume-raid-info'
.SS ac
Alias of 'access-group-create'
.SS aa

[Gris Ge]

* Replace incorrect constant 'Pool.RAID_TYPE_UNKNOWN' with
'Volume.RAID_TYPE_UNKNOWN'.

Signed-off-by: Gris Ge <***@redhat.com>
---
plugin/ontap/ontap.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugin/ontap/ontap.py b/plugin/ontap/ontap.py
index 6cf8cd5..5e50a44 100644
--- a/plugin/ontap/ontap.py
+++ b/plugin/ontap/ontap.py
@@ -1294,7 +1294,7 @@ class Ontap(IStorageAreaNetwork, INfs):
return Volume.RAID_TYPE_RAID4
elif 'raid_dp' in na_raid_statuses:
return Volume.RAID_TYPE_RAID6
- return Pool.RAID_TYPE_UNKNOWN
+ return Volume.RAID_TYPE_UNKNOWN

@handle_ontap_errors
def volume_raid_info(self, volume, flags=0):

[Tony Asleson]

Looks good, patch series committed!

Thanks,
Tony

Post by Gris Ge
* ONTAP plugin fixes.
* lsmcli manpage update.
ONTAP Plugin: Add missing capability VOLUME_RAID_INFO.
ONTAP Plugin: Fix bug an incorrect constant.
lsmcli: Add missing manpage entries for volume-raid-info command.
doc/man/lsmcli.1.in | 9 +++++++++
plugin/ontap/ontap.py | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)