Discussion:
[Libstoragemgmt-devel] [RFC] Please review the file-level API in wiki page
Gris Ge
2014-05-06 13:21:48 UTC
Permalink
Hi all,

Please review this wiki page for file-level Python API.
For the file system snapshot and clone, please refer to next email for
discuss.

Besides trivial rename, I would like start a discussion on this:

* lsm.Client.exports() vs lsm.NfsExport
# I would suggest we unify them into:
# * lsm.Client.nfs_exports()
# * lsm.Client.fs_nfs_export()
# * lsm.Client.fs_nfs_unexport()
# * lsm.NfsExport

As we have no support of CIFS in existing codes yet and clearly will
continue to be un-supported for a while, I would suggest we add 'nfs'
into methods naming.
Once we reviewed CIFS plugin support status, we can adding these for
CIFS and NFS(by keeping the method/class above for NFS only):
* lsm.Export
* lsm.Client.exports()
* lsm.Client.fs_export()
* lsm.Client.fs_unexport()

Any thoughts?

Thank you in advance.
Best regards.
--
Gris Ge
Gris Ge
2014-05-06 13:22:43 UTC
Permalink
Post by Gris Ge
Hi all,
Please review this wiki page for file-level Python API.
Oops. Forgot the URL:
https://sourceforge.net/p/libstoragemgmt/wiki/Python_API_Usage/
--
Gris Ge
Tony Asleson
2014-05-06 17:17:04 UTC
Permalink
Post by Gris Ge
Hi all,
Please review this wiki page for file-level Python API.
I believe the fs_create/fs_delete/fs_resize look fine on the wiki.
Post by Gris Ge
* lsm.Client.exports() vs lsm.NfsExport
# * lsm.Client.nfs_exports()
# * lsm.Client.fs_nfs_export()
# * lsm.Client.fs_nfs_unexport()
# * lsm.NfsExport
As we have no support of CIFS in existing codes yet and clearly will
continue to be un-supported for a while, I would suggest we add 'nfs'
into methods naming.
Once we reviewed CIFS plugin support status, we can adding these for
* lsm.Export
* lsm.Client.exports()
* lsm.Client.fs_export()
* lsm.Client.fs_unexport()
Any thoughts?
I'm fine with a simple re-name, but I don't see how we can unify these
cleanly. The parameters/setup for NFS & CIFS are quite different so I
was planning on them being separate things and not try to merge them
into anything common.

I would rather have two separate sets of calls which clearly meet the
users expectations than a mix of the two.

Regards,
Tony

Loading...