Discussion:
[Libstoragemgmt-devel] [PATCH] fix bug of inner
Ma Shimiao
2014-04-21 08:07:21 UTC
Permalink
Signed-off-by: Ma Shimiao <***@cn.fujitsu.com>
---
lsm/lsm/_common.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lsm/lsm/_common.py b/lsm/lsm/_common.py
index 19b0a24..65a6cce 100644
--- a/lsm/lsm/_common.py
+++ b/lsm/lsm/_common.py
@@ -550,8 +550,8 @@ def return_requires(*types):
is quite important.
"""
def outer(func):
- def inner(*args):
- r = func(*args)
+ def inner(*args, **kwargs):
+ r = func(*args, **kwargs)

# In this case the user did something like
# @return_requires(int, string, int)
--
1.8.3.1
Gris Ge
2014-04-21 08:21:00 UTC
Permalink
Post by Ma Shimiao
---
lsm/lsm/_common.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Hi Ma Shimiao,

Thanks for the patch.
It just passed by my test using these two:
* cli.volume_create( pools[0], 'abcd', 1024, 1, 0)
* cli.volume_create(pool=pools[0], volume_name='abc', size_bytes=1024,
provisioning=1, flags=0)

I will leave it to Tony for review and commit.

Best regards.
--
Gris Ge
MaShimiao
2014-04-21 08:24:44 UTC
Permalink
Post by Gris Ge
Post by Ma Shimiao
---
lsm/lsm/_common.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Hi Ma Shimiao,
Thanks for the patch.
* cli.volume_create( pools[0], 'abcd', 1024, 1, 0)
* cli.volume_create(pool=pools[0], volume_name='abc', size_bytes=1024,
provisioning=1, flags=0)
I will leave it to Tony for review and commit.
OK. Thank you for your test.

Best regards.
Post by Gris Ge
Best regards.
--
Ma Shimiao
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
Tony Asleson
2014-04-21 14:58:36 UTC
Permalink
Patch looks good, pushed!

Thank you!
-Tony
Post by MaShimiao
Post by Gris Ge
Post by Ma Shimiao
---
lsm/lsm/_common.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Hi Ma Shimiao,
Thanks for the patch.
* cli.volume_create( pools[0], 'abcd', 1024, 1, 0)
* cli.volume_create(pool=pools[0], volume_name='abc', size_bytes=1024,
provisioning=1, flags=0)
I will leave it to Tony for review and commit.
OK. Thank you for your test.
Best regards.
Post by Gris Ge
Best regards.
Loading...