[Libstoragemgmt-devel] [PATCH] lsmd: add error catch for signal

[Ma Shimiao]

Signed-off-by: Ma Shimiao <***@cn.fujitsu.com>
---
daemon/lsm_daemon.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/daemon/lsm_daemon.c b/daemon/lsm_daemon.c
index acc8ef5..58b86ff 100644
--- a/daemon/lsm_daemon.c
+++ b/daemon/lsm_daemon.c
@@ -137,8 +137,13 @@ void signal_handler(int s)
*/
void install_sh(void)
{
- signal(SIGTERM, signal_handler);
- signal(SIGHUP, signal_handler);
+ if(signal(SIGTERM, signal_handler) == SIG_ERR) {
+ loud("Can't catch signal SIGTERM\n");
+ }
+
+ if(signal(SIGHUP, signal_handler) == SIG_ERR) {
+ loud("Can't catch signal SIGHUP\n");
+ }
}

/**

[Ma Shimiao]

If we can't install signal handler successfully, then we can't
get correct status of deamon.
So, I think this is a serious problem to loud print.

Signed-off-by: Ma Shimiao <***@cn.fujitsu.com>
---
daemon/lsm_daemon.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/daemon/lsm_daemon.c b/daemon/lsm_daemon.c
index acc8ef5..58b86ff 100644
--- a/daemon/lsm_daemon.c
+++ b/daemon/lsm_daemon.c
@@ -137,8 +137,13 @@ void signal_handler(int s)
*/
void install_sh(void)
{
- signal(SIGTERM, signal_handler);
- signal(SIGHUP, signal_handler);
+ if(signal(SIGTERM, signal_handler) == SIG_ERR) {
+ loud("Can't catch signal SIGTERM\n");
+ }
+
+ if(signal(SIGHUP, signal_handler) == SIG_ERR) {
+ loud("Can't catch signal SIGHUP\n");
+ }
}

/**

[Ma Shimiao]

Ping

Post by Ma Shimiao
If we can't install signal handler successfully, then we can't
get correct status of deamon.
So, I think this is a serious problem to loud print.
---
daemon/lsm_daemon.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/daemon/lsm_daemon.c b/daemon/lsm_daemon.c
index acc8ef5..58b86ff 100644
--- a/daemon/lsm_daemon.c
+++ b/daemon/lsm_daemon.c
@@ -137,8 +137,13 @@ void signal_handler(int s)
*/
void install_sh(void)
{
- signal(SIGTERM, signal_handler);
- signal(SIGHUP, signal_handler);
+ if(signal(SIGTERM, signal_handler) == SIG_ERR) {
+ loud("Can't catch signal SIGTERM\n");
+ }
+
+ if(signal(SIGHUP, signal_handler) == SIG_ERR) {
+ loud("Can't catch signal SIGHUP\n");
+ }
}
/**