Tony Asleson
2014-10-31 23:13:15 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via d83cea9074d9b663a919671273aee86c26d20d87 (commit)
via d1947e5951592fe77d312ca163b5c4490abfeb92 (commit)
from 9b6d9e30b6ce71ccd7c51a2bca948c911f4eb208 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d83cea9074d9b663a919671273aee86c26d20d87
Author: Gris Ge <***@redhat.com>
Date: Fri Oct 31 22:36:23 2014 +0800
LSM REST Daemon: Fix memory leak.
* This patch was inspired by a patch from Christophe Fergeau and coverity
scan report from Tony Asleson.
* Fixed all valgrind reported memory leak except one possibly leak:
# RHEL 7 libmicrohttpd-0.9.33-2.el7.x86_64, valgrind-3.9.0-6.el7.x86_64
==17008== 272 bytes in 1 blocks are possibly lost in loss record 58 of 83
==17008== at 0x4C2A1D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==17008== by 0x4011EB4: _dl_allocate_tls (dl-tls.c:318)
==17008== by 0x631B9A0: pthread_create@@GLIBC_2.2.5 (allocatestack.c:570)
==17008== by 0x4E3A13F: create_thread (daemon.c:979)
==17008== by 0x4E3F258: MHD_start_daemon_va (daemon.c:3628)
==17008== by 0x4E3FC6C: MHD_start_daemon (daemon.c:2666)
==17008== by 0x401429: main (lsm_rest.c:513)
Signed-off-by: Gris Ge <***@redhat.com>
commit d1947e5951592fe77d312ca163b5c4490abfeb92
Author: Gris Ge <***@redhat.com>
Date: Thu Oct 30 21:24:19 2014 +0800
RPM SPEC: Add OpenSuSE support.
* This is based on rpm SPEC provided by Nick Wang <***@suse.com>.
* Use %if 0%{?suse_version} to use SuSE only setting.
* Replaced '/bin/systemctl' command with %systemd_xxx macros which was
provided by /usr/lib/rpm/macros.d/macros.systemd by systemd rpm.
# For SuSE, they use %service_xxx instead.
* Removed command "systemctl enable libstoragemgmt.service".
We should use systemd.preset instead.
For RHEL 7 and Fedora, systemd.preset enabled libstoragemgmt.service.
So nothing actual changed.
* Add %post script to libstoragemgmt-rest package.
* Make sure all folder is owned by certain rpm package by add lines like:
%dir %{python_sitelib}/lsm/plugin/sim
* Move 'libstoragemgmt-rest.service' systemd file to libstoragemgmt-rest
package. (Old RPM SPEC was including it in libstoragemgmt.rpm)
* On openSuSE, the package name has been changed due to their share lib naming
policy[1]:
libstoragemgmt-devel
libstoragemgmt-udev
libstoragemgmt1
libstoragemgmt1-python
libstoragemgmt1-smis-plugin
libstoragemgmt1-netapp-plugin
libstoragemgmt1-targetd-plugin
libstoragemgmt1-nstor-plugin
libstoragemgmt1-rest
* Run fdupes on OpenSuSE to create soft link against duplicated
python .pyo and .pyc files.
For Fedora, it will conflict with brp-python-bytecompile.
For RHEL, fdupes is in EPEL repo.
* Move '/var/run/lsm' folder creation to %pre script as a rpm package should
not own a ghost file in /var/run which might be mounted as tmpfs.
* Add %post and %postun scripts into plugin package to 'try-restart'
the libstoragemgmt.service when new install or package removal.
This is only for systemd as RHEL 6 does not have 'try-restart' feature yet.
* On openSuSE, use 'LGPL-2.1+' string due to openSuSE requirements.
* Compile pass on OBS for Fedora 19/20, RHEL 6/7, OpenSuSE 13.1/13.2
* Manually tested via 'lsmcli lp' against simulator C and python plugin,
smispy plugin, ontap plugin and targetd plugin on these OS:
* RHEL 6.5 x86_64
* RHEL 7.0 x86_64
* Fedora 20 x86_64
* OpenSuSE 13.1 x86_64
[1] https://en.opensuse.org/openSUSE:Shared_library_packaging_policy
Changes in V2:
* Removed unneeded _libexecdir for openSuSE as suggested by Nick Wang.
Changes in V3:
* Removed the "don't commit" comments.
Signed-off-by: Gris Ge <***@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
daemon/lsm_rest.c | 115 ++++++++----
daemon/lsm_rest.h | 2 +
packaging/libstoragemgmt.spec.in | 398 ++++++++++++++++++++++++++------------
3 files changed, 356 insertions(+), 159 deletions(-)
hooks/post-receive
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via d83cea9074d9b663a919671273aee86c26d20d87 (commit)
via d1947e5951592fe77d312ca163b5c4490abfeb92 (commit)
from 9b6d9e30b6ce71ccd7c51a2bca948c911f4eb208 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d83cea9074d9b663a919671273aee86c26d20d87
Author: Gris Ge <***@redhat.com>
Date: Fri Oct 31 22:36:23 2014 +0800
LSM REST Daemon: Fix memory leak.
* This patch was inspired by a patch from Christophe Fergeau and coverity
scan report from Tony Asleson.
* Fixed all valgrind reported memory leak except one possibly leak:
# RHEL 7 libmicrohttpd-0.9.33-2.el7.x86_64, valgrind-3.9.0-6.el7.x86_64
==17008== 272 bytes in 1 blocks are possibly lost in loss record 58 of 83
==17008== at 0x4C2A1D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==17008== by 0x4011EB4: _dl_allocate_tls (dl-tls.c:318)
==17008== by 0x631B9A0: pthread_create@@GLIBC_2.2.5 (allocatestack.c:570)
==17008== by 0x4E3A13F: create_thread (daemon.c:979)
==17008== by 0x4E3F258: MHD_start_daemon_va (daemon.c:3628)
==17008== by 0x4E3FC6C: MHD_start_daemon (daemon.c:2666)
==17008== by 0x401429: main (lsm_rest.c:513)
Signed-off-by: Gris Ge <***@redhat.com>
commit d1947e5951592fe77d312ca163b5c4490abfeb92
Author: Gris Ge <***@redhat.com>
Date: Thu Oct 30 21:24:19 2014 +0800
RPM SPEC: Add OpenSuSE support.
* This is based on rpm SPEC provided by Nick Wang <***@suse.com>.
* Use %if 0%{?suse_version} to use SuSE only setting.
* Replaced '/bin/systemctl' command with %systemd_xxx macros which was
provided by /usr/lib/rpm/macros.d/macros.systemd by systemd rpm.
# For SuSE, they use %service_xxx instead.
* Removed command "systemctl enable libstoragemgmt.service".
We should use systemd.preset instead.
For RHEL 7 and Fedora, systemd.preset enabled libstoragemgmt.service.
So nothing actual changed.
* Add %post script to libstoragemgmt-rest package.
* Make sure all folder is owned by certain rpm package by add lines like:
%dir %{python_sitelib}/lsm/plugin/sim
* Move 'libstoragemgmt-rest.service' systemd file to libstoragemgmt-rest
package. (Old RPM SPEC was including it in libstoragemgmt.rpm)
* On openSuSE, the package name has been changed due to their share lib naming
policy[1]:
libstoragemgmt-devel
libstoragemgmt-udev
libstoragemgmt1
libstoragemgmt1-python
libstoragemgmt1-smis-plugin
libstoragemgmt1-netapp-plugin
libstoragemgmt1-targetd-plugin
libstoragemgmt1-nstor-plugin
libstoragemgmt1-rest
* Run fdupes on OpenSuSE to create soft link against duplicated
python .pyo and .pyc files.
For Fedora, it will conflict with brp-python-bytecompile.
For RHEL, fdupes is in EPEL repo.
* Move '/var/run/lsm' folder creation to %pre script as a rpm package should
not own a ghost file in /var/run which might be mounted as tmpfs.
* Add %post and %postun scripts into plugin package to 'try-restart'
the libstoragemgmt.service when new install or package removal.
This is only for systemd as RHEL 6 does not have 'try-restart' feature yet.
* On openSuSE, use 'LGPL-2.1+' string due to openSuSE requirements.
* Compile pass on OBS for Fedora 19/20, RHEL 6/7, OpenSuSE 13.1/13.2
* Manually tested via 'lsmcli lp' against simulator C and python plugin,
smispy plugin, ontap plugin and targetd plugin on these OS:
* RHEL 6.5 x86_64
* RHEL 7.0 x86_64
* Fedora 20 x86_64
* OpenSuSE 13.1 x86_64
[1] https://en.opensuse.org/openSUSE:Shared_library_packaging_policy
Changes in V2:
* Removed unneeded _libexecdir for openSuSE as suggested by Nick Wang.
Changes in V3:
* Removed the "don't commit" comments.
Signed-off-by: Gris Ge <***@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
daemon/lsm_rest.c | 115 ++++++++----
daemon/lsm_rest.h | 2 +
packaging/libstoragemgmt.spec.in | 398 ++++++++++++++++++++++++++------------
3 files changed, 356 insertions(+), 159 deletions(-)
hooks/post-receive
--
libstoragemgmt
------------------------------------------------------------------------------
libstoragemgmt
------------------------------------------------------------------------------