Tony Asleson
2014-08-06 00:00:52 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via 7e6763ea62df1e06c37ffb7f37b9afc22b9041a4 (commit)
via ad57771f9f3f50b192f962925b642a40aa406b32 (commit)
via 048cdde01183b4c4101efab21f0caddc263fb88a (commit)
via 22a6de467a3948d3c25ee9d7a9a1b5c91e39d0b8 (commit)
via 3e0adeaba4dc76ef3504a97ee68c314fd9cdab6e (commit)
via ab6ec709b3e74c5ea0b60b7065e3972f74193081 (commit)
via 92c95d667f0147b49d471638fcd7aacea706fffb (commit)
via 3096f7f03673dc80fe8160dff19388d889297db1 (commit)
via 378398c0187acda9ed6cfa1a282daffbe483d59a (commit)
via 665bf0c43472e2d8268e1b11d0912c8e0b7c599d (commit)
via 2d2fd890ad1877382235d819d6f19d75e401e684 (commit)
via 0339d9ac527d8d17774f77069691880423b5d7f6 (commit)
via d16f1b5699888d557f66a3266e07deb38f5682fe (commit)
via 716f4ee8689d618f9b3ec9ff7828ae8288419a2f (commit)
via f038135167680eb1e83b7ba0e3bdf0c21a1fb535 (commit)
via 49da053e9ba4c6caec6defd61efbea76fc82ee4b (commit)
via d07a22983ff8f92f63f119bc28f57662fe0168ea (commit)
from 7fedb758978c36d6762df8fbabadb1c9c165fac9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7e6763ea62df1e06c37ffb7f37b9afc22b9041a4
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 22:56:32 2014 +0800
SMI-S plugin: revert to old capability check agains BSP profile
Revert to old way of checking CIM_StorageConfigurationCapabilities about
setting capabilities of VOLUMES, VOLUME_CREATE, VOLUME_DELETE, VOLUME_RESIZE.
Signed-off-by: Gris Ge <***@redhat.com>
commit ad57771f9f3f50b192f962925b642a40aa406b32
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 22:56:31 2014 +0800
SMI-S plugin: Remove un-needed _INIT_TYPE_CONV
Just some left-over since 'Remove INIT_TYPE_WWNN and etc unused initiator
type' patch.
Signed-off-by: Gris Ge <***@redhat.com>
commit 048cdde01183b4c4101efab21f0caddc263fb88a
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 12:03:43 2014 +0800
lsmcli: add alias to lsmcli to save some time
* Just save some(for me, it's a lot) time of keyboard typing.
'lsmcli ls' == 'lsmcli list --type systems'
* In python 3, they have 'aliases' argument for add_parser(), but
it cannot handle alias string with argument.
* Workflow(kind of twisted):
1. The list: aliases contained all aliases.
2. Call add_parser() for each alias.
3. Set functional for each alias to be handle_alias().
4. Use parse_known_args() to allowing unknown arguments.
5. Save unknown arguments to self.unknown_args.
6. The handle_alias() will combine original command and self.unknown_args.
7. The handle_alias() call parse_args() and func()
* I only included my often used command to alias. We can add the missing
commands later.
Signed-off-by: Gris Ge <***@redhat.com>
commit 22a6de467a3948d3c25ee9d7a9a1b5c91e39d0b8
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:56 2014 +0800
SMI-S plugin: Fix access group bugs
* Fix these problems:
1. _cim_init_check_or_create() incorrect return CIMInstanceName when
creation needed.
# Now, method renamed to _cim_init_path_check_or_create().
# will return CIMInstanceName always.
2. The confliction error will be raise as CIMError in InvokeMethod()
command, not in _wait_invoke() method.
# Now, we do confliction check when error happened.
# Not check pre-excute, which can save some time for most legal use.
Changes in V2:
1. Thanks to Tony's detailed review, these issue fixed:
smis.py line 4906 & 4935, cim_init_mg_pros not defined
smis.py line 4916, out_init_id not defined
Signed-off-by: Gris Ge <***@redhat.com>
commit 3e0adeaba4dc76ef3504a97ee68c314fd9cdab6e
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:55 2014 +0800
SMI-S plugin: standardize the WWPN
* Convert SNIA format WWPN to LSM format before saving in AccessGroup.
* Convert LSM WWPN to SNIA format before sending to WBEM.
Signed-off-by: Gris Ge <***@redhat.com>
commit ab6ec709b3e74c5ea0b60b7065e3972f74193081
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:54 2014 +0800
ontap plugin: Rename INVALID_IQN to INVALID_INIT
Rename ErrorNumber.INVALID_IQN to ErrorNumber.INVALID_INIT.
Signed-off-by: Gris Ge <***@redhat.com>
commit 92c95d667f0147b49d471638fcd7aacea706fffb
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:53 2014 +0800
lsmcli: Remove --init-type argument
* Remove '--init-type' by auto detecting user input.
* Manpage updated.
* cmdtest.py updated.
Signed-off-by: Gris Ge <***@redhat.com>
commit 3096f7f03673dc80fe8160dff19388d889297db1
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:52 2014 +0800
C API: Rename LSM_ERR_INVALID_IQN to LSM_ERR_INVALID_INIT
* Remove old LSM_ERR_INVALID_INIT which is not cleaned up by last initiator
class removal.
* Rename LSM_ERR_INVALID_IQN to LSM_ERR_INVALID_INIT.
Signed-off-by: Gris Ge <***@redhat.com>
commit 378398c0187acda9ed6cfa1a282daffbe483d59a
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:51 2014 +0800
Python API: standardize the WWPN
1. Forcing user to input WWPN in this format:
10:00:00:00:c9:95:2f:de
2. Add methods to lsm.AccessGroup:
AccessGroup.init_id_validate()
AccessGroup.wwpn_to_lsm_type()
3. Rename INVALID_IQN to INVALID_INIT
Signed-off-by: Gris Ge <***@redhat.com>
commit 665bf0c43472e2d8268e1b11d0912c8e0b7c599d
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:50 2014 +0800
Remove INIT_TYPE_WWNN and etc unused initiator type
* Removed these initiator types as no plugin is using them:
INIT_TYPE_WWNN (Python)
INIT_TYPE_HOSTNAME (Python)
INIT_TYPE_SAS (Python)
LSM_ACCESS_GROUP_INIT_TYPE_WWNN (C)
LSM_ACCESS_GROUP_INIT_TYPE_HOSTNAME (C)
LSM_ACCESS_GROUP_INIT_TYPE_SAS (C)
* Update plugins for above changes.
* Renamed this type in C API:
INIT_TYPE_ISCSI_WWPN_MIXED to LSM_ACCESS_GROUP_INIT_TYPE_ISCSI_WWPN_MIXED
* Removed old initiator class in C API:
1. Renamed lsm_initiator_type to lsm_access_group_init_type
2. Removed lsm_plug_initiator_grant() method
3. Removed _lsm_initiator class.
* Fix incorrect parameter of lsm_iscsi_chap_auth:
initiator -> init_id
* Enabled iscsi_chap_auth test.
Signed-off-by: Gris Ge <***@redhat.com>
commit 2d2fd890ad1877382235d819d6f19d75e401e684
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:49 2014 +0800
lsmcli: use python-ordereddict for python <= 2.6
OrderedDict is only available in python 2.7.[1]
We use it from python-ordereddict package which is a backport version.
Tested on RHEL 6.2 which does not port OrderedDict from 2.7 yet.
Signed-off-by: Gris Ge <***@redhat.com>
commit 0339d9ac527d8d17774f77069691880423b5d7f6
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:48 2014 +0800
test: empty expected_absent capabilities check
The 'simc://' and 'sim://' plugins are not sharing the same list of
UNSUPPORTED capabilities.
Before sync the behaviour of these two plugins, I would like to make test pass
by empty expected_absent capabilities check
Signed-off-by: Gris Ge <***@redhat.com>
commit d16f1b5699888d557f66a3266e07deb38f5682fe
Author: Tony Asleson <***@redhat.com>
Date: Tue Aug 5 10:48:47 2014 +0800
C API V3: Simplify lsm_capability_set_n
More than once the call to lsm_capability_set_n has been done incorrectly
when adding or removing capabilities. Christophe offered this good suggestion:
"
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via 7e6763ea62df1e06c37ffb7f37b9afc22b9041a4 (commit)
via ad57771f9f3f50b192f962925b642a40aa406b32 (commit)
via 048cdde01183b4c4101efab21f0caddc263fb88a (commit)
via 22a6de467a3948d3c25ee9d7a9a1b5c91e39d0b8 (commit)
via 3e0adeaba4dc76ef3504a97ee68c314fd9cdab6e (commit)
via ab6ec709b3e74c5ea0b60b7065e3972f74193081 (commit)
via 92c95d667f0147b49d471638fcd7aacea706fffb (commit)
via 3096f7f03673dc80fe8160dff19388d889297db1 (commit)
via 378398c0187acda9ed6cfa1a282daffbe483d59a (commit)
via 665bf0c43472e2d8268e1b11d0912c8e0b7c599d (commit)
via 2d2fd890ad1877382235d819d6f19d75e401e684 (commit)
via 0339d9ac527d8d17774f77069691880423b5d7f6 (commit)
via d16f1b5699888d557f66a3266e07deb38f5682fe (commit)
via 716f4ee8689d618f9b3ec9ff7828ae8288419a2f (commit)
via f038135167680eb1e83b7ba0e3bdf0c21a1fb535 (commit)
via 49da053e9ba4c6caec6defd61efbea76fc82ee4b (commit)
via d07a22983ff8f92f63f119bc28f57662fe0168ea (commit)
from 7fedb758978c36d6762df8fbabadb1c9c165fac9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7e6763ea62df1e06c37ffb7f37b9afc22b9041a4
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 22:56:32 2014 +0800
SMI-S plugin: revert to old capability check agains BSP profile
Revert to old way of checking CIM_StorageConfigurationCapabilities about
setting capabilities of VOLUMES, VOLUME_CREATE, VOLUME_DELETE, VOLUME_RESIZE.
Signed-off-by: Gris Ge <***@redhat.com>
commit ad57771f9f3f50b192f962925b642a40aa406b32
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 22:56:31 2014 +0800
SMI-S plugin: Remove un-needed _INIT_TYPE_CONV
Just some left-over since 'Remove INIT_TYPE_WWNN and etc unused initiator
type' patch.
Signed-off-by: Gris Ge <***@redhat.com>
commit 048cdde01183b4c4101efab21f0caddc263fb88a
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 12:03:43 2014 +0800
lsmcli: add alias to lsmcli to save some time
* Just save some(for me, it's a lot) time of keyboard typing.
'lsmcli ls' == 'lsmcli list --type systems'
* In python 3, they have 'aliases' argument for add_parser(), but
it cannot handle alias string with argument.
* Workflow(kind of twisted):
1. The list: aliases contained all aliases.
2. Call add_parser() for each alias.
3. Set functional for each alias to be handle_alias().
4. Use parse_known_args() to allowing unknown arguments.
5. Save unknown arguments to self.unknown_args.
6. The handle_alias() will combine original command and self.unknown_args.
7. The handle_alias() call parse_args() and func()
* I only included my often used command to alias. We can add the missing
commands later.
Signed-off-by: Gris Ge <***@redhat.com>
commit 22a6de467a3948d3c25ee9d7a9a1b5c91e39d0b8
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:56 2014 +0800
SMI-S plugin: Fix access group bugs
* Fix these problems:
1. _cim_init_check_or_create() incorrect return CIMInstanceName when
creation needed.
# Now, method renamed to _cim_init_path_check_or_create().
# will return CIMInstanceName always.
2. The confliction error will be raise as CIMError in InvokeMethod()
command, not in _wait_invoke() method.
# Now, we do confliction check when error happened.
# Not check pre-excute, which can save some time for most legal use.
Changes in V2:
1. Thanks to Tony's detailed review, these issue fixed:
smis.py line 4906 & 4935, cim_init_mg_pros not defined
smis.py line 4916, out_init_id not defined
Signed-off-by: Gris Ge <***@redhat.com>
commit 3e0adeaba4dc76ef3504a97ee68c314fd9cdab6e
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:55 2014 +0800
SMI-S plugin: standardize the WWPN
* Convert SNIA format WWPN to LSM format before saving in AccessGroup.
* Convert LSM WWPN to SNIA format before sending to WBEM.
Signed-off-by: Gris Ge <***@redhat.com>
commit ab6ec709b3e74c5ea0b60b7065e3972f74193081
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:54 2014 +0800
ontap plugin: Rename INVALID_IQN to INVALID_INIT
Rename ErrorNumber.INVALID_IQN to ErrorNumber.INVALID_INIT.
Signed-off-by: Gris Ge <***@redhat.com>
commit 92c95d667f0147b49d471638fcd7aacea706fffb
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:53 2014 +0800
lsmcli: Remove --init-type argument
* Remove '--init-type' by auto detecting user input.
* Manpage updated.
* cmdtest.py updated.
Signed-off-by: Gris Ge <***@redhat.com>
commit 3096f7f03673dc80fe8160dff19388d889297db1
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:52 2014 +0800
C API: Rename LSM_ERR_INVALID_IQN to LSM_ERR_INVALID_INIT
* Remove old LSM_ERR_INVALID_INIT which is not cleaned up by last initiator
class removal.
* Rename LSM_ERR_INVALID_IQN to LSM_ERR_INVALID_INIT.
Signed-off-by: Gris Ge <***@redhat.com>
commit 378398c0187acda9ed6cfa1a282daffbe483d59a
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:51 2014 +0800
Python API: standardize the WWPN
1. Forcing user to input WWPN in this format:
10:00:00:00:c9:95:2f:de
2. Add methods to lsm.AccessGroup:
AccessGroup.init_id_validate()
AccessGroup.wwpn_to_lsm_type()
3. Rename INVALID_IQN to INVALID_INIT
Signed-off-by: Gris Ge <***@redhat.com>
commit 665bf0c43472e2d8268e1b11d0912c8e0b7c599d
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:50 2014 +0800
Remove INIT_TYPE_WWNN and etc unused initiator type
* Removed these initiator types as no plugin is using them:
INIT_TYPE_WWNN (Python)
INIT_TYPE_HOSTNAME (Python)
INIT_TYPE_SAS (Python)
LSM_ACCESS_GROUP_INIT_TYPE_WWNN (C)
LSM_ACCESS_GROUP_INIT_TYPE_HOSTNAME (C)
LSM_ACCESS_GROUP_INIT_TYPE_SAS (C)
* Update plugins for above changes.
* Renamed this type in C API:
INIT_TYPE_ISCSI_WWPN_MIXED to LSM_ACCESS_GROUP_INIT_TYPE_ISCSI_WWPN_MIXED
* Removed old initiator class in C API:
1. Renamed lsm_initiator_type to lsm_access_group_init_type
2. Removed lsm_plug_initiator_grant() method
3. Removed _lsm_initiator class.
* Fix incorrect parameter of lsm_iscsi_chap_auth:
initiator -> init_id
* Enabled iscsi_chap_auth test.
Signed-off-by: Gris Ge <***@redhat.com>
commit 2d2fd890ad1877382235d819d6f19d75e401e684
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:49 2014 +0800
lsmcli: use python-ordereddict for python <= 2.6
OrderedDict is only available in python 2.7.[1]
We use it from python-ordereddict package which is a backport version.
Tested on RHEL 6.2 which does not port OrderedDict from 2.7 yet.
Signed-off-by: Gris Ge <***@redhat.com>
commit 0339d9ac527d8d17774f77069691880423b5d7f6
Author: Gris Ge <***@redhat.com>
Date: Tue Aug 5 10:48:48 2014 +0800
test: empty expected_absent capabilities check
The 'simc://' and 'sim://' plugins are not sharing the same list of
UNSUPPORTED capabilities.
Before sync the behaviour of these two plugins, I would like to make test pass
by empty expected_absent capabilities check
Signed-off-by: Gris Ge <***@redhat.com>
commit d16f1b5699888d557f66a3266e07deb38f5682fe
Author: Tony Asleson <***@redhat.com>
Date: Tue Aug 5 10:48:47 2014 +0800
C API V3: Simplify lsm_capability_set_n
More than once the call to lsm_capability_set_n has been done incorrectly
when adding or removing capabilities. Christophe offered this good suggestion:
"