Tony Asleson
2014-11-25 21:59:46 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via 16290b2ec7a18e60de69590adb67f0067c677743 (commit)
via 49cba85df716ed07e74cb89c7f0b726cbbdf0d49 (commit)
via 7ec0f645a5b60bb15249fe08737da3b4b64feccc (commit)
via 38ba43abf6b4bfff12d32c59370f60ce506fc272 (commit)
via 72ea8baec29b31e7f1c498df62b6cbec1896198b (commit)
via a151af6343cd7a09fb1e3bbcc11b7b071eec101b (commit)
via b82ff1c66b298314fb0389ab1308ec9c0dc37ed0 (commit)
via 0634582636aac76f746b484f12655c6d8ba1c64f (commit)
via c089df9703ee56f867147754ebdc84723c266f34 (commit)
via 9a752adcf99c559221453909b605fba95ac26fd0 (commit)
via 5a5f4a7a2290aa63968bd589680f2d43dc220f8f (commit)
via e783e20aaffab697631aa6688d4b34a25f9090c3 (commit)
from ad9e6e99071d6b1c32ba88e29674160273305582 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 16290b2ec7a18e60de69590adb67f0067c677743
Author: Tony Asleson <***@redhat.com>
Date: Tue Nov 25 15:32:21 2014 -0600
plugin_test.py: Pep8 cleanup.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 49cba85df716ed07e74cb89c7f0b726cbbdf0d49
Author: Tony Asleson <***@redhat.com>
Date: Tue Nov 25 15:31:27 2014 -0600
plugin_test.py: Don't log exceptions for expected things
During testing we force a number of different exceptions. For those that
we force, don't log them. The exception will still be raised and the
test case will still do asserts to ensure we are getting them when we are
suppose too.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 7ec0f645a5b60bb15249fe08737da3b4b64feccc
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:28 2014 +0800
Plugin Test: Add NAME_CONFLICT and EXISTS_INITIATOR tests of access_group_create()
* Add new tests for access_group_create():
1. Check NAME_CONFLICT for access group name confliction.
2. Check EXISTS_INITIATOR for initiator confliction.
Signed-off-by: Gris Ge <***@redhat.com>
commit 38ba43abf6b4bfff12d32c59370f60ce506fc272
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:27 2014 +0800
Simulator C Plugin: Raise EXISTS_INITIATOR in access_group_create()
* Raise LSM_ERR_EXISTS_INITIATOR if requested initiator is already used
by other access group.
* Added new private method _find_dup_init() to check initiator confliction.
Changes in V2:
* Remove incorrect lsm_string_list_free() in _find_dup_init().
Signed-off-by: Gris Ge <***@redhat.com>
commit 72ea8baec29b31e7f1c498df62b6cbec1896198b
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:25 2014 +0800
ONTAP Plugin: Improve error handling in access_group_create()
* Raise EXISTS_INITIATOR error if requested initiator is used by other
access group on access_group_create().
* Due to some unknown bug of NetApp, their array sometimes does not
raise error on initiator confliction. Hence we cannot use
'try then expect' way.
(Found problem on real hardware 8.0.2 and simulator 8.1.1)
* When plugin failed to find out the newly created access group,
previous code will raise NOT_FOUND_ACCESS_GROUP.
This patch changed it to PLUGIN_BUG, as NOT_FOUND_ACCESS_GROUP is only
for user input parameter.
* Tested on NetApp ONTAP simulator 8.1.1.
Signed-off-by: Gris Ge <***@redhat.com>
commit a151af6343cd7a09fb1e3bbcc11b7b071eec101b
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:24 2014 +0800
SMI-S Plugin: Raise error for duplicate call of access_group_create()
* Raise EXISTS_INITIATOR when requested initiator is already used by other
access group on access_group_create().
* Tested on EMC VMAX for EXISTS_INITIATOR error.
Signed-off-by: Gris Ge <***@redhat.com>
commit b82ff1c66b298314fb0389ab1308ec9c0dc37ed0
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:50 2014 +0800
Plugin Test: Add NO_STATE_CHANGE error detection for volume mask and unmask.
* Plugin should raise NO_STATE_CHANGE when volume already masked on
volume_mask()
* Plugin should raise NO_STATE_CHANGE when volume is not masked on
volume_unmask()
Signed-off-by: Gris Ge <***@redhat.com>
commit 0634582636aac76f746b484f12655c6d8ba1c64f
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:49 2014 +0800
Simulator C Plugin: Raise LSM_ERR_NO_STATE_CHANGE when not masked.
* Raise LSM_ERR_NO_STATE_CHANGE when volume is not masked to requested
access group on volume_unmask().
Signed-off-by: Gris Ge <***@redhat.com>
commit c089df9703ee56f867147754ebdc84723c266f34
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:48 2014 +0800
Nstor Plugin: Raise NO_STATE_CHANGE when already masked.
* Raise NO_STATE_CHANGE error when volume is already masked on
volume_mask().
* As nstor will not raise error on duplicate volume mask, we have to
do a pre-check via volumes_accessible_by_access_group() method.
Signed-off-by: Gris Ge <***@redhat.com>
commit 9a752adcf99c559221453909b605fba95ac26fd0
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:47 2014 +0800
ONTAP Plugin: Raise NO_STATE_CHANGE error if already unmasked.
* Raise NO_STATE_CHANGE if volume_unmask() against unmasked relationship.
* Check EVDISK_ERROR_NO_SUCH_LUNMAP filer error for this condition.
Signed-off-by: Gris Ge <***@redhat.com>
commit 5a5f4a7a2290aa63968bd589680f2d43dc220f8f
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:46 2014 +0800
Targetd Plugin: Raise NO_STATE_CHANGE error if not masked or already masked.
* Raise LsmError ErrorNumber.NO_STATE_CHANGE in
volume_mask and volume_unmask if already masked or not masked.
Changes in V2:
* New private method _is_masked() used in volume_mask() and volume_unmask()
to detect masking status of requesting volume.
Changes in V3:
* Changed _is_masked() to return tuple (boolean, tgt_masks). This was done
because volume_mask needs the tgt_masks to determine the lowest unused
logical unit number.
Signed-off-by: Gris Ge <***@redhat.com>
Signed-off-by: Tony Asleson <***@redhat.com>
commit e783e20aaffab697631aa6688d4b34a25f9090c3
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:45 2014 +0800
SMI-S Plugin: Raise NO_STATE_CHANGE error if not masked or already masked.
* Raise LsmError ErrorNumber.NO_STATE_CHANGE in
volume_mask and volume_unmask if already masked or not masked.
* Introduced new method:
smis_ag.cim_vols_masked_to_cim_spc_path()
# To get all masked cim_vols for give cim_spc.
* Tested on EMC VNX for 'Masking and Mapping' profile.
* Tested on EMC VMAX for 'Group Masking and Mapping' profile.
* Full plugin_test passed on:
* EMC VMAX
* EMC VNX
* HP 3PAR
Changes in V2:
* Fix typo of 'requestd'.
* Remove unneeded check for ag_cim_spcs_path in _volume_unmask_group().
* New private method: _cim_vol_masked_to_spc() used in _volume_unmask_old()
and _volume_mask_old().
Changes in V3:
* _volume_unmask_old: remove call to cim_vol_id_pros before calling
_cim_vol_masked_to_spc as this is already handled in the
implementation of _cim_vol_masked_to_spc.
Signed-off-by: Gris Ge <***@redhat.com>
Signed-off-by: Tony Asleson <***@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
plugin/nstor/nstor.py | 8 ++
plugin/ontap/na.py | 1 +
plugin/ontap/ontap.py | 37 ++++++--
plugin/simc/simc_lsmplugin.c | 86 ++++++++++++----
plugin/smispy/smis.py | 203 ++++++++++++++++++++-----------------
plugin/smispy/smis_ag.py | 21 ++++
plugin/targetd/targetd.py | 39 +++++--
test/plugin_test.py | 228 +++++++++++++++++++++++++++---------------
8 files changed, 406 insertions(+), 217 deletions(-)
hooks/post-receive
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via 16290b2ec7a18e60de69590adb67f0067c677743 (commit)
via 49cba85df716ed07e74cb89c7f0b726cbbdf0d49 (commit)
via 7ec0f645a5b60bb15249fe08737da3b4b64feccc (commit)
via 38ba43abf6b4bfff12d32c59370f60ce506fc272 (commit)
via 72ea8baec29b31e7f1c498df62b6cbec1896198b (commit)
via a151af6343cd7a09fb1e3bbcc11b7b071eec101b (commit)
via b82ff1c66b298314fb0389ab1308ec9c0dc37ed0 (commit)
via 0634582636aac76f746b484f12655c6d8ba1c64f (commit)
via c089df9703ee56f867147754ebdc84723c266f34 (commit)
via 9a752adcf99c559221453909b605fba95ac26fd0 (commit)
via 5a5f4a7a2290aa63968bd589680f2d43dc220f8f (commit)
via e783e20aaffab697631aa6688d4b34a25f9090c3 (commit)
from ad9e6e99071d6b1c32ba88e29674160273305582 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 16290b2ec7a18e60de69590adb67f0067c677743
Author: Tony Asleson <***@redhat.com>
Date: Tue Nov 25 15:32:21 2014 -0600
plugin_test.py: Pep8 cleanup.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 49cba85df716ed07e74cb89c7f0b726cbbdf0d49
Author: Tony Asleson <***@redhat.com>
Date: Tue Nov 25 15:31:27 2014 -0600
plugin_test.py: Don't log exceptions for expected things
During testing we force a number of different exceptions. For those that
we force, don't log them. The exception will still be raised and the
test case will still do asserts to ensure we are getting them when we are
suppose too.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 7ec0f645a5b60bb15249fe08737da3b4b64feccc
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:28 2014 +0800
Plugin Test: Add NAME_CONFLICT and EXISTS_INITIATOR tests of access_group_create()
* Add new tests for access_group_create():
1. Check NAME_CONFLICT for access group name confliction.
2. Check EXISTS_INITIATOR for initiator confliction.
Signed-off-by: Gris Ge <***@redhat.com>
commit 38ba43abf6b4bfff12d32c59370f60ce506fc272
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:27 2014 +0800
Simulator C Plugin: Raise EXISTS_INITIATOR in access_group_create()
* Raise LSM_ERR_EXISTS_INITIATOR if requested initiator is already used
by other access group.
* Added new private method _find_dup_init() to check initiator confliction.
Changes in V2:
* Remove incorrect lsm_string_list_free() in _find_dup_init().
Signed-off-by: Gris Ge <***@redhat.com>
commit 72ea8baec29b31e7f1c498df62b6cbec1896198b
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:25 2014 +0800
ONTAP Plugin: Improve error handling in access_group_create()
* Raise EXISTS_INITIATOR error if requested initiator is used by other
access group on access_group_create().
* Due to some unknown bug of NetApp, their array sometimes does not
raise error on initiator confliction. Hence we cannot use
'try then expect' way.
(Found problem on real hardware 8.0.2 and simulator 8.1.1)
* When plugin failed to find out the newly created access group,
previous code will raise NOT_FOUND_ACCESS_GROUP.
This patch changed it to PLUGIN_BUG, as NOT_FOUND_ACCESS_GROUP is only
for user input parameter.
* Tested on NetApp ONTAP simulator 8.1.1.
Signed-off-by: Gris Ge <***@redhat.com>
commit a151af6343cd7a09fb1e3bbcc11b7b071eec101b
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 16:49:24 2014 +0800
SMI-S Plugin: Raise error for duplicate call of access_group_create()
* Raise EXISTS_INITIATOR when requested initiator is already used by other
access group on access_group_create().
* Tested on EMC VMAX for EXISTS_INITIATOR error.
Signed-off-by: Gris Ge <***@redhat.com>
commit b82ff1c66b298314fb0389ab1308ec9c0dc37ed0
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:50 2014 +0800
Plugin Test: Add NO_STATE_CHANGE error detection for volume mask and unmask.
* Plugin should raise NO_STATE_CHANGE when volume already masked on
volume_mask()
* Plugin should raise NO_STATE_CHANGE when volume is not masked on
volume_unmask()
Signed-off-by: Gris Ge <***@redhat.com>
commit 0634582636aac76f746b484f12655c6d8ba1c64f
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:49 2014 +0800
Simulator C Plugin: Raise LSM_ERR_NO_STATE_CHANGE when not masked.
* Raise LSM_ERR_NO_STATE_CHANGE when volume is not masked to requested
access group on volume_unmask().
Signed-off-by: Gris Ge <***@redhat.com>
commit c089df9703ee56f867147754ebdc84723c266f34
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:48 2014 +0800
Nstor Plugin: Raise NO_STATE_CHANGE when already masked.
* Raise NO_STATE_CHANGE error when volume is already masked on
volume_mask().
* As nstor will not raise error on duplicate volume mask, we have to
do a pre-check via volumes_accessible_by_access_group() method.
Signed-off-by: Gris Ge <***@redhat.com>
commit 9a752adcf99c559221453909b605fba95ac26fd0
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:47 2014 +0800
ONTAP Plugin: Raise NO_STATE_CHANGE error if already unmasked.
* Raise NO_STATE_CHANGE if volume_unmask() against unmasked relationship.
* Check EVDISK_ERROR_NO_SUCH_LUNMAP filer error for this condition.
Signed-off-by: Gris Ge <***@redhat.com>
commit 5a5f4a7a2290aa63968bd589680f2d43dc220f8f
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:46 2014 +0800
Targetd Plugin: Raise NO_STATE_CHANGE error if not masked or already masked.
* Raise LsmError ErrorNumber.NO_STATE_CHANGE in
volume_mask and volume_unmask if already masked or not masked.
Changes in V2:
* New private method _is_masked() used in volume_mask() and volume_unmask()
to detect masking status of requesting volume.
Changes in V3:
* Changed _is_masked() to return tuple (boolean, tgt_masks). This was done
because volume_mask needs the tgt_masks to determine the lowest unused
logical unit number.
Signed-off-by: Gris Ge <***@redhat.com>
Signed-off-by: Tony Asleson <***@redhat.com>
commit e783e20aaffab697631aa6688d4b34a25f9090c3
Author: Gris Ge <***@redhat.com>
Date: Tue Nov 25 15:31:45 2014 +0800
SMI-S Plugin: Raise NO_STATE_CHANGE error if not masked or already masked.
* Raise LsmError ErrorNumber.NO_STATE_CHANGE in
volume_mask and volume_unmask if already masked or not masked.
* Introduced new method:
smis_ag.cim_vols_masked_to_cim_spc_path()
# To get all masked cim_vols for give cim_spc.
* Tested on EMC VNX for 'Masking and Mapping' profile.
* Tested on EMC VMAX for 'Group Masking and Mapping' profile.
* Full plugin_test passed on:
* EMC VMAX
* EMC VNX
* HP 3PAR
Changes in V2:
* Fix typo of 'requestd'.
* Remove unneeded check for ag_cim_spcs_path in _volume_unmask_group().
* New private method: _cim_vol_masked_to_spc() used in _volume_unmask_old()
and _volume_mask_old().
Changes in V3:
* _volume_unmask_old: remove call to cim_vol_id_pros before calling
_cim_vol_masked_to_spc as this is already handled in the
implementation of _cim_vol_masked_to_spc.
Signed-off-by: Gris Ge <***@redhat.com>
Signed-off-by: Tony Asleson <***@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
plugin/nstor/nstor.py | 8 ++
plugin/ontap/na.py | 1 +
plugin/ontap/ontap.py | 37 ++++++--
plugin/simc/simc_lsmplugin.c | 86 ++++++++++++----
plugin/smispy/smis.py | 203 ++++++++++++++++++++-----------------
plugin/smispy/smis_ag.py | 21 ++++
plugin/targetd/targetd.py | 39 +++++--
test/plugin_test.py | 228 +++++++++++++++++++++++++++---------------
8 files changed, 406 insertions(+), 217 deletions(-)
hooks/post-receive
--
libstoragemgmt
libstoragemgmt