Tony Asleson
2014-08-28 14:27:06 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via 04f540d7ac94b46a48c064c07c984b060b49eea1 (commit)
via 46723dd6e2e436902f8156289df377e37fe103c2 (commit)
via 609bbd31c264b085f4c07dbe6c0cbe3edfaba6f4 (commit)
via e678f2d5a96e1661196c28c0f56b52241964fc18 (commit)
via ed528ec59bb0f189bd1b531259fb9f49555e59ea (commit)
via 5f1d3d48342c3ebe78694a72f4f1e7040029cca7 (commit)
via 10b6db01052ce62a2a9a2a460522648e55857ec6 (commit)
from f715b41caffc29506c1a80be9b9d6abe620578e7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 04f540d7ac94b46a48c064c07c984b060b49eea1
Author: Tony Asleson <***@redhat.com>
Date: Wed Aug 27 18:10:31 2014 -0500
C & PY: Introduce unsupported_actions to pool
Some arrays don't support all features for all pools. Add propery
so that we can convey this information.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 46723dd6e2e436902f8156289df377e37fe103c2
Author: Tony Asleson <***@redhat.com>
Date: Wed Aug 27 14:34:39 2014 -0500
PY & C: Fix up constants
Using Gris's check_const.pl script I re-worked the code base
so that the constants match as expected. I also removed a couple
of fields from the C error structure that we weren't really
leveraging: error level and error domain. Some other constants
were removed as well. The check_const.pl script has been
incorporated into the `make check` process and will fail the
build if the script detects any inconsistencies.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 609bbd31c264b085f4c07dbe6c0cbe3edfaba6f4
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:57 2014 +0800
Python Library: Trivial change: Allow script to easily check constants
* No API changes.
* Just make the life of constant checker script easier.
Signed-off-by: Gris Ge <***@redhat.com>
commit e678f2d5a96e1661196c28c0f56b52241964fc18
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:56 2014 +0800
C Library: Rename LSM_CAPABILITY_XXX to LSM_CAP_XXX
* Rename LSM_CAPABILITY_SUPPORTED to LSM_CAP_SUPPORTED
* Rename LSM_CAPABILITY_UNSUPPORTED to LSM_CAP_UNSUPPORTED
* Just matching with other LSM_CAP_XXX constants naming scheme.
Signed-off-by: Gris Ge <***@redhat.com>
commit ed528ec59bb0f189bd1b531259fb9f49555e59ea
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:55 2014 +0800
Rename Disk.DISK_TYPE_XXX to Disk.DISK
* Just to match C library name:
LSM_DISK_TYPE_XXX
Signed-off-by: Gris Ge <***@redhat.com>
commit 5f1d3d48342c3ebe78694a72f4f1e7040029cca7
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:54 2014 +0800
Utils: New script to compare constants in Python and C library
Sorry for hurting your eyes again with perl voodoo regex.
Generally this script compare constants in Python and C library using known
name conversion(please check py_name_2_c_name()):
1. Convert CaMel to CA_MEL
2. Convert System to SYSTEM
3. Convert Capabilities to CAP and etc using %PY_CLASS_NAME_CONV;
The report will be like:
=====
PASS lsm.Volume.REPLICATE_SNAPSHOT 1(1)
LSM_VOLUME_REPLICATE_SNAPSHOT 1(1)
PY_MISS ACCESS_GROUP_MASKED 502(502)
C_MISS lsm.Disk.STATUS_REMOVED 1 << 5(32)
FAIL lsm.Fake.FAKE_NAME 1 << 5(32)
LSM_FAKE_FAKE_NAME 0x000010(16)
=====
It found many missing, no failure in current code tree.
We will discuss and patch them later.
Signed-off-by: Gris Ge <***@redhat.com>
commit 10b6db01052ce62a2a9a2a460522648e55857ec6
Author: Tony Asleson <***@redhat.com>
Date: Tue Aug 26 10:08:16 2014 -0500
plugin_test.py: Add test for IS_MASKED
Ensure we get an IS_MASKED error if we try to delete a volume
that is masked against an access group.
Tested against sim & simc
Signed-off-by: Tony Asleson <***@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
c_binding/include/libstoragemgmt/libstoragemgmt.h | 2 +-
.../libstoragemgmt/libstoragemgmt_capabilities.h | 4 +-
.../include/libstoragemgmt/libstoragemgmt_error.h | 36 +--
.../libstoragemgmt/libstoragemgmt_plug_interface.h | 27 +-
.../include/libstoragemgmt/libstoragemgmt_pool.h | 7 +
.../include/libstoragemgmt/libstoragemgmt_types.h | 54 +--
c_binding/lsm_convert.cpp | 2 +
c_binding/lsm_datatypes.cpp | 47 +--
c_binding/lsm_datatypes.hpp | 5 +-
c_binding/lsm_mgmt.cpp | 5 +-
c_binding/lsm_plugin_ipc.cpp | 6 +-
configure.ac | 6 +
packaging/libstoragemgmt.spec.in | 2 +-
plugin/nstor/nstor.py | 1 +
plugin/ontap/ontap.py | 36 +-
plugin/sim/simarray.py | 52 ++-
plugin/simc/simc_lsmplugin.c | 59 ++-
plugin/smispy/smis.py | 70 ++-
plugin/targetd/targetd.py | 2 +-
python_binding/lsm/__init__.py | 2 +-
python_binding/lsm/_client.py | 6 +
python_binding/lsm/_common.py | 7 -
python_binding/lsm/_data.py | 71 ++--
test/plugin_test.py | 30 +-
test/runtests.sh | 3 +
test/tester.c | 523 ++++++++++----------
tools/Makefile.am | 2 +-
tools/lsmcli/data_display.py | 50 ++-
tools/utility/Makefile.am | 1 +
tools/utility/check_const.pl | 489 ++++++++++++++++++
30 files changed, 1063 insertions(+), 544 deletions(-)
create mode 100644 tools/utility/Makefile.am
create mode 100644 tools/utility/check_const.pl
hooks/post-receive
generated because a ref change was pushed to the repository containing
the project "libstoragemgmt".
The branch, master has been updated
via 04f540d7ac94b46a48c064c07c984b060b49eea1 (commit)
via 46723dd6e2e436902f8156289df377e37fe103c2 (commit)
via 609bbd31c264b085f4c07dbe6c0cbe3edfaba6f4 (commit)
via e678f2d5a96e1661196c28c0f56b52241964fc18 (commit)
via ed528ec59bb0f189bd1b531259fb9f49555e59ea (commit)
via 5f1d3d48342c3ebe78694a72f4f1e7040029cca7 (commit)
via 10b6db01052ce62a2a9a2a460522648e55857ec6 (commit)
from f715b41caffc29506c1a80be9b9d6abe620578e7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 04f540d7ac94b46a48c064c07c984b060b49eea1
Author: Tony Asleson <***@redhat.com>
Date: Wed Aug 27 18:10:31 2014 -0500
C & PY: Introduce unsupported_actions to pool
Some arrays don't support all features for all pools. Add propery
so that we can convey this information.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 46723dd6e2e436902f8156289df377e37fe103c2
Author: Tony Asleson <***@redhat.com>
Date: Wed Aug 27 14:34:39 2014 -0500
PY & C: Fix up constants
Using Gris's check_const.pl script I re-worked the code base
so that the constants match as expected. I also removed a couple
of fields from the C error structure that we weren't really
leveraging: error level and error domain. Some other constants
were removed as well. The check_const.pl script has been
incorporated into the `make check` process and will fail the
build if the script detects any inconsistencies.
Signed-off-by: Tony Asleson <***@redhat.com>
commit 609bbd31c264b085f4c07dbe6c0cbe3edfaba6f4
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:57 2014 +0800
Python Library: Trivial change: Allow script to easily check constants
* No API changes.
* Just make the life of constant checker script easier.
Signed-off-by: Gris Ge <***@redhat.com>
commit e678f2d5a96e1661196c28c0f56b52241964fc18
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:56 2014 +0800
C Library: Rename LSM_CAPABILITY_XXX to LSM_CAP_XXX
* Rename LSM_CAPABILITY_SUPPORTED to LSM_CAP_SUPPORTED
* Rename LSM_CAPABILITY_UNSUPPORTED to LSM_CAP_UNSUPPORTED
* Just matching with other LSM_CAP_XXX constants naming scheme.
Signed-off-by: Gris Ge <***@redhat.com>
commit ed528ec59bb0f189bd1b531259fb9f49555e59ea
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:55 2014 +0800
Rename Disk.DISK_TYPE_XXX to Disk.DISK
* Just to match C library name:
LSM_DISK_TYPE_XXX
Signed-off-by: Gris Ge <***@redhat.com>
commit 5f1d3d48342c3ebe78694a72f4f1e7040029cca7
Author: Gris Ge <***@redhat.com>
Date: Wed Aug 27 19:55:54 2014 +0800
Utils: New script to compare constants in Python and C library
Sorry for hurting your eyes again with perl voodoo regex.
Generally this script compare constants in Python and C library using known
name conversion(please check py_name_2_c_name()):
1. Convert CaMel to CA_MEL
2. Convert System to SYSTEM
3. Convert Capabilities to CAP and etc using %PY_CLASS_NAME_CONV;
The report will be like:
=====
PASS lsm.Volume.REPLICATE_SNAPSHOT 1(1)
LSM_VOLUME_REPLICATE_SNAPSHOT 1(1)
PY_MISS ACCESS_GROUP_MASKED 502(502)
C_MISS lsm.Disk.STATUS_REMOVED 1 << 5(32)
FAIL lsm.Fake.FAKE_NAME 1 << 5(32)
LSM_FAKE_FAKE_NAME 0x000010(16)
=====
It found many missing, no failure in current code tree.
We will discuss and patch them later.
Signed-off-by: Gris Ge <***@redhat.com>
commit 10b6db01052ce62a2a9a2a460522648e55857ec6
Author: Tony Asleson <***@redhat.com>
Date: Tue Aug 26 10:08:16 2014 -0500
plugin_test.py: Add test for IS_MASKED
Ensure we get an IS_MASKED error if we try to delete a volume
that is masked against an access group.
Tested against sim & simc
Signed-off-by: Tony Asleson <***@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
c_binding/include/libstoragemgmt/libstoragemgmt.h | 2 +-
.../libstoragemgmt/libstoragemgmt_capabilities.h | 4 +-
.../include/libstoragemgmt/libstoragemgmt_error.h | 36 +--
.../libstoragemgmt/libstoragemgmt_plug_interface.h | 27 +-
.../include/libstoragemgmt/libstoragemgmt_pool.h | 7 +
.../include/libstoragemgmt/libstoragemgmt_types.h | 54 +--
c_binding/lsm_convert.cpp | 2 +
c_binding/lsm_datatypes.cpp | 47 +--
c_binding/lsm_datatypes.hpp | 5 +-
c_binding/lsm_mgmt.cpp | 5 +-
c_binding/lsm_plugin_ipc.cpp | 6 +-
configure.ac | 6 +
packaging/libstoragemgmt.spec.in | 2 +-
plugin/nstor/nstor.py | 1 +
plugin/ontap/ontap.py | 36 +-
plugin/sim/simarray.py | 52 ++-
plugin/simc/simc_lsmplugin.c | 59 ++-
plugin/smispy/smis.py | 70 ++-
plugin/targetd/targetd.py | 2 +-
python_binding/lsm/__init__.py | 2 +-
python_binding/lsm/_client.py | 6 +
python_binding/lsm/_common.py | 7 -
python_binding/lsm/_data.py | 71 ++--
test/plugin_test.py | 30 +-
test/runtests.sh | 3 +
test/tester.c | 523 ++++++++++----------
tools/Makefile.am | 2 +-
tools/lsmcli/data_display.py | 50 ++-
tools/utility/Makefile.am | 1 +
tools/utility/check_const.pl | 489 ++++++++++++++++++
30 files changed, 1063 insertions(+), 544 deletions(-)
create mode 100644 tools/utility/Makefile.am
create mode 100644 tools/utility/check_const.pl
hooks/post-receive
--
libstoragemgmt
libstoragemgmt