Discussion:
[Libstoragemgmt-devel] [PATCH] data_display.py: Remove _txt_a
Tony Asleson
2014-07-30 23:00:21 UTC
Permalink
Changed to mory pythonic way as suggested by
Grover.

Signed-off-by: Tony Asleson <***@redhat.com>
---
tools/lsmcli/data_display.py | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/tools/lsmcli/data_display.py b/tools/lsmcli/data_display.py
index 50d61c7..a4d9629 100644
--- a/tools/lsmcli/data_display.py
+++ b/tools/lsmcli/data_display.py
@@ -40,22 +40,15 @@ def out(msg):
sys.exit(1)


-def _txt_a(txt, append):
- if len(txt):
- return txt + BIT_MAP_STRING_SPLITTER + append
- else:
- return append
-
-
def _bit_map_to_str(bit_map, conv_dict):
- rc = ''
+ rc = []
bit_map = int(bit_map)
for cur_enum in conv_dict.keys():
if cur_enum & bit_map:
- rc = _txt_a(rc, conv_dict[cur_enum])
- if rc == '':
+ rc.append(conv_dict[cur_enum])
+ if len(rc) == 0:
return 'Unknown(%s)' % hex(bit_map)
- return rc
+ return BIT_MAP_STRING_SPLITTER.join(rc)


def _enum_type_to_str(int_type, conv_dict):
--
1.8.2.1
Loading...