Gris Ge
2016-02-18 13:35:37 UTC
Rename lsm_scsi_xxx to lsm_local_disk_xxx as we support ATA protocol disks also.
In the future, we might also support NVMe disks as well.
Include other fixes:
* Fix constant check.
* Eliminate duplicate code by using some C macros.
* Split large functions to smaller one in lsm_scsi_vpd83_of_disk_path().
Please check github pull request for detail:
https://github.com/libstorage/libstoragemgmt/pull/92
Gris Ge (7):
Constants Test: Add support of negative number and all uppercase
module.
Constants test: fix incorrect hex constant parsing.
Test: Fix running make check by root user.
Improve lsm_scsi_vpd83_of_disk_path().
C API: Use macro _good() to replace duplicate code
Python C extension: Eliminate duplicate code.
API rename: lsm_scsi_xxx to lsm_local_disk_xxx.
c_binding/Makefile.am | 2 +-
c_binding/include/libstoragemgmt/Makefile.am | 2 +-
c_binding/include/libstoragemgmt/libstoragemgmt.h | 2 +-
.../include/libstoragemgmt/libstoragemgmt_disk.h | 2 +-
.../libstoragemgmt/libstoragemgmt_local_disk.h | 79 +++
.../include/libstoragemgmt/libstoragemgmt_scsi.h | 77 ---
c_binding/lsm_local_disk.c | 760 +++++++++++++++++++++
c_binding/lsm_scsi.c | 615 -----------------
packaging/libstoragemgmt.spec.in | 4 +-
plugin/hpsa/hpsa.py | 4 +-
python_binding/Makefile.am | 14 +-
python_binding/lsm/__init__.py | 2 +-
python_binding/lsm/_clib.c | 181 +++++
python_binding/lsm/_local_disk.py | 87 +++
python_binding/lsm/_scsi.py | 86 ---
python_binding/lsm/_scsi_clib.c | 221 ------
test/test_include.sh | 14 +-
test/tester.c | 114 ++--
tools/lsmcli/cmdline.py | 4 +-
tools/utility/check_const.pl | 18 +-
20 files changed, 1204 insertions(+), 1084 deletions(-)
create mode 100644 c_binding/include/libstoragemgmt/libstoragemgmt_local_disk.h
delete mode 100644 c_binding/include/libstoragemgmt/libstoragemgmt_scsi.h
create mode 100644 c_binding/lsm_local_disk.c
delete mode 100644 c_binding/lsm_scsi.c
create mode 100644 python_binding/lsm/_clib.c
create mode 100644 python_binding/lsm/_local_disk.py
delete mode 100644 python_binding/lsm/_scsi.py
delete mode 100644 python_binding/lsm/_scsi_clib.c
In the future, we might also support NVMe disks as well.
Include other fixes:
* Fix constant check.
* Eliminate duplicate code by using some C macros.
* Split large functions to smaller one in lsm_scsi_vpd83_of_disk_path().
Please check github pull request for detail:
https://github.com/libstorage/libstoragemgmt/pull/92
Gris Ge (7):
Constants Test: Add support of negative number and all uppercase
module.
Constants test: fix incorrect hex constant parsing.
Test: Fix running make check by root user.
Improve lsm_scsi_vpd83_of_disk_path().
C API: Use macro _good() to replace duplicate code
Python C extension: Eliminate duplicate code.
API rename: lsm_scsi_xxx to lsm_local_disk_xxx.
c_binding/Makefile.am | 2 +-
c_binding/include/libstoragemgmt/Makefile.am | 2 +-
c_binding/include/libstoragemgmt/libstoragemgmt.h | 2 +-
.../include/libstoragemgmt/libstoragemgmt_disk.h | 2 +-
.../libstoragemgmt/libstoragemgmt_local_disk.h | 79 +++
.../include/libstoragemgmt/libstoragemgmt_scsi.h | 77 ---
c_binding/lsm_local_disk.c | 760 +++++++++++++++++++++
c_binding/lsm_scsi.c | 615 -----------------
packaging/libstoragemgmt.spec.in | 4 +-
plugin/hpsa/hpsa.py | 4 +-
python_binding/Makefile.am | 14 +-
python_binding/lsm/__init__.py | 2 +-
python_binding/lsm/_clib.c | 181 +++++
python_binding/lsm/_local_disk.py | 87 +++
python_binding/lsm/_scsi.py | 86 ---
python_binding/lsm/_scsi_clib.c | 221 ------
test/test_include.sh | 14 +-
test/tester.c | 114 ++--
tools/lsmcli/cmdline.py | 4 +-
tools/utility/check_const.pl | 18 +-
20 files changed, 1204 insertions(+), 1084 deletions(-)
create mode 100644 c_binding/include/libstoragemgmt/libstoragemgmt_local_disk.h
delete mode 100644 c_binding/include/libstoragemgmt/libstoragemgmt_scsi.h
create mode 100644 c_binding/lsm_local_disk.c
delete mode 100644 c_binding/lsm_scsi.c
create mode 100644 python_binding/lsm/_clib.c
create mode 100644 python_binding/lsm/_local_disk.py
delete mode 100644 python_binding/lsm/_scsi.py
delete mode 100644 python_binding/lsm/_scsi_clib.c
--
2.7.1
2.7.1